Is this ok, and what can I do to improve it?